-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: StandardDatabase.fetch_transaction
(#329)
#331
Conversation
344867a
to
52c214f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the prompt followup!
Looks good overall and the logic is correct (also docs example is nice). The only thing which should be addressed is in executor.py
, but that's merely a simplification.
52c214f
to
26e22b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me!
Unfortunately the docs CI is complaining of duplicate keys. Just use some different names in the example.
26e22b5
to
75c2c99
Compare
75c2c99
to
9d210e2
Compare
I see that there are some failing checks still, but they don't seem to be related to anything I've touched or something that should have been impacted by my changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing docs test is due to the fact that Pregel has been deprecated recently. That's an update we'll have to make on our end.
Thank you for your contribution!
Resolves #329.
Introduces a new method
fetch_transaction
on StandardDatabase that allows users to create a TransactionDatabase based on an existing Transaction, instead of starting a new transaction.