New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constraints #5

Merged

weikengchen merged 7 commits into master from add-constraints

Nov 2, 2020

Member

Pratyush commented Nov 1, 2020

No description provided.

Pratyush and others added 2 commits

October 31, 2020 19:21

WIP

def0569


          add constraints, first attempt

4f148cc

weikengchen requested a review from npwardberkeley

November 1, 2020 05:40

Member

weikengchen commented Nov 1, 2020

Done. Please take a look. If okay, I will likely use this as a start for Gm17.

weikengchen mentioned this pull request

Add constraints arkworks-rs/gm17#4

Merged

Pratyush commented

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

Pratyush commented

View reviewed changes

src/constraints.rs Outdated Show resolved Hide resolved

Pratyush commented

View reviewed changes

src/constraints.rs Outdated Show resolved Hide resolved

Pratyush commented

View reviewed changes

src/constraints.rs Outdated Show resolved Hide resolved

Pratyush commented

View reviewed changes

src/constraints.rs Outdated Show resolved Hide resolved

Pratyush commented

View reviewed changes

src/constraints.rs Outdated Show resolved Hide resolved

Pratyush commented

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

Pratyush commented

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved


          Apply suggestions from code review

ed358ef

Co-authored-by: Pratyush Mishra <[email protected]>

npwardberkeley approved these changes

View reviewed changes

npwardberkeley left a comment

very minor comments

src/constraints.rs Show resolved Hide resolved

src/constraints.rs Outdated Show resolved Hide resolved

src/constraints.rs Outdated Show resolved Hide resolved

src/constraints.rs Show resolved Hide resolved

weikengchen added 4 commits

November 2, 2020 12:00


          apply the comments

83b0ba3


          Merge branch 'add-constraints' of github.com:arkworks-rs/groth16 into…

2bc602c

… add-constraints

fix

fix

df56189

weikengchen merged commit 8332334 into master

weikengchen deleted the add-constraints branch

November 2, 2020 20:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet