Install Qemu on GH actions hosts #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HugoSilvaSantos
commented
Apr 16, 2025
•
HugoSilvaSantos
commented
- The missing package is causing an error when running build.sh
- Ensure the workflow only runs on the arm-toolchain repository
- The missing package is causing an error when running build.sh
pratlucas
reviewed
Apr 16, 2025
| @@ -14,7 +14,8 @@ sudo apt-get update && sudo apt-get install -y --no-install-recommends \ | |||
| ninja-build=1.10.1-1 \ | |||
| clang=1:14.0-55~exp2 \ | |||
| python3-pip \ | |||
| python3-setuptools | |||
| python3-setuptools \ | |||
| qemu-system-x86=1:6.2+dfsg-2ubuntu6.26 | |||
There was a problem hiding this comment.
I believe qemu-system-x86 will not include the arm and aarch64 emulation we need to run our tests. The package needed is probably qemu instead.
There was a problem hiding this comment.
The latest commit adds support to:
- qemu-system-x86_64 --version
- qemu-system-arm --version
- qemu-system-aarch64 --version
There was a problem hiding this comment.
qemu-system-x86_64 is not needed: installing the qemu-system-arm package should be sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.