Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -shared from Windows release artifacts #237

Closed
indygreg opened this issue Mar 19, 2024 · 1 comment
Closed

Remove -shared from Windows release artifacts #237

indygreg opened this issue Mar 19, 2024 · 1 comment

Comments

@indygreg
Copy link
Collaborator

Windows static builds were removed in #234.

We preserved the -shared target triple suffix for the moment. But it is no longer needed, as its sole role was to disambiguate the static and shared Windows builds. Since there is now only a single variant, no such label is needed.

If we remove the -shared suffix, there will be consumers who will need to update code to point to the new value. We may want to consider double publishing the -shared and sans--shared release artifacts during a transition period to avoid forced breakage. The download stats can be used to determine when it is safe to stop publishing the -shared artifacts.

@charliermarsh
Copy link
Member

I can take this follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants