Remove Windows static builds #234
Conversation
charliermarsh
force-pushed
the
charlie/win-static
branch
from
c7dd6a9 to
ea639ab
Compare
There was a problem hiding this comment.
As I reviewed all the deleted code, I couldn't help but reflect on how many hours it took to devise those lines of code. Dozens. If not over 100.
It was a bold experiment. But sometimes you can only learn through failure.
Thank you for this PR: it looks great!
| @@ -48,8 +48,7 @@ pub static RELEASE_TRIPLES: Lazy<BTreeMap<&'static str, TripleRelease>> = Lazy:: | |||
|
|
|||
| // Windows. | |||
|
|
|||
| // The -shared and -static parts of the triple are a lie. But the code | |||
| // handles it fine. | |||
| // The -shared part of the triple is a lie. But the code handles it fine. | |||
There was a problem hiding this comment.
As a potential future followup we can strip the -shared part from the triple. The only reason it is there is to disambiguate from the static builds. Now since there are only dynamically linked builds, there's no need for the label.
I'll file an issue to track this.
There was a problem hiding this comment.
Cool, I can do that too.
Honestly... I guessed as much. There were so many little details here in the static library conversion, |
Summary
This PR removes the Windows static builds from the build and release pipelines. As per #221:
Closes #221.