Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to
requires-python
in certain cases whentarget-version
is not found #16319Fallback to
requires-python
in certain cases whentarget-version
is not found #16319Changes from all commits
7bbda72
186235a
92bc35a
7c2c9b1
812fb20
759c0ba
cc7d0bb
c8c10cd
3c3c812
9fbe52a
4a2d9e1
cd37ed8
7f4403f
3613121
1b52717
e2b30e9
9039594
7e1f777
0d99dba
081518a
3c45426
2a20b69
123006f
513b1c8
5f3ec8c
2d22b76
511129e
ac55239
54acafa
a1a7548
b098255
229e905
6093d74
f5d0203
49a593e
dc26d44
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract the path into a variable and use it both in
find_fallback_target_version
and when callinginto_settings
. It required me few cycles to understand whetherpath_dedot::CWD
is correct but I then noticed that it's already whatinto_setting
usesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, it depends on what behavior we want.
The way I have it currently set up I'm trying to make the behavior change as little as possible, so I've kept the settings resolution path the same no matter what, but attempted to find a fallback version using the same logic as we did when searching for a user configuration file. That logic would start from the stdin filename directory if it was passed in.
In other words, I don't think I can extract a
path
variable here since I may be passing a different value tofind_fallback_target_version
than I am tointo_settings
.