Skip to content

Cluster provider should be shut down before actor system starts shutting down #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

Cluster provider should be shut down before actor system starts shutting down #1798

merged 1 commit into from
Oct 12, 2022

Conversation

jstnlef
Copy link
Contributor

@jstnlef jstnlef commented Oct 11, 2022 •
edited
Loading

Description

Changes shutdown order to

  1. Send Gossip shutdown message
  2. Provider
  3. System to stop various loop tasks
  4. Gossip to kill the gossip actor
  5. IdentityLookup to kill its actors
  6. Remote to disconnect from all of the other nodes

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@jstnlef jstnlef force-pushed the more-shutdown-fixes branch from 6006c1e to 9bc90b1 Compare October 11, 2022 17:57
@jstnlef jstnlef changed the title I believe that the cluster provider should be the first to shut down I believe that the cluster provider should be shut down before actor system starts shutting down Oct 11, 2022
@jstnlef jstnlef changed the title I believe that the cluster provider should be shut down before actor system starts shutting down Cluster provider should be shut down before actor system starts shutting down Oct 11, 2022
@rogeralsing rogeralsing merged commit 261f15b into asynkron:dev Oct 12, 2022
@jstnlef jstnlef deleted the more-shutdown-fixes branch October 13, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstnlef @rogeralsing