[WIP] Config #62
Closed
[WIP] Config #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major bug though currently since config appears to clobber functions:
atom.config.get('script.grammars.Perl')["File Based"]()
TypeError: Property 'File Based' of object #<Object> is not a function
atom.config.get('script.grammars.Perl')["File Based"]
Object {}
|
Closing in favor of using other configurables
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a config to script, addressing #5.
There are major issues though.
One is the fact that functions in the config get clobbered/coerced into empty object literals. To get around this I opted for using a "flags" array.
This brings us to the next issue. If there are no flags specified within the default or the settings pane,
atom.configjust doesn't pass that on. This makes it hard to tell the difference between a program that can't handle selections or just plain doesn't have flags.Also, the config screen is ugly. See what it does with capital letters in keys?