This repository was archived by the owner on Dec 15, 2022. It is now read-only.
call super in derived classes #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of coffeescript throws an error so I'm assuming super isn't automatically inserted
Maybe it worked previously because Node doesn't have an explicit constructor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
At atom/atom#22099 section Motivation, I saw that there's an error:
Description of the Change
Calls super in those classes
Alternate Designs
None
Possible Drawbacks
I'm not sure why super wasn't called in the first place, maybe I'm missing something.
Verification Process
Release Notes
Call super in derived classes