-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ASE interface and SchNetPack ASE calculator #418
Conversation
stress: str = "stress", | ||
model_file: str, | ||
neighbor_list: schnetpack.transform.Transform, | ||
energy_label: str = "energy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i called this "_key" instead of "_label" in other modules. should be consistent one or they other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also use "_key" in the gschnet code, I think it is more precise than "_label"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed energy_label
, force_label
and stress_label
to energy_key
, force_key
and stress_key
, as well as position_units
and energy_units
to position_unit
and energy_unit
. Now everything is consistent with the atomistic
module. The changes affect the ASE and MD calculators, as well as the MD configs.
Updated the
SpkCalculator
andASEInterface
to follow the input conventions of the MD calculators. Changes to both include:AtomsConverter
a neighbor list is passed. This allows better consistency when handing device and precision optionsAtomsConverter
SpkCalculator
Moved the utility function
_activate_stress
from the SchNetPack MD calculator tomd/utils/activate_model_stress
and updated to account for changes in overall model structure and derivative handling.Updated tutorials 2 and 3 to reflect the changes in the ASE interface.