Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bug and updates to new simpy verison #658

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fixes bug and updates to new simpy verison #658

merged 2 commits into from
Aug 28, 2024

Conversation

stefaanhessmann
Copy link
Collaborator

  • New simpy version caused problems with numpy inputs (ValueError('expecting integer or half-integer, got 0')). Just using the torch tensors instead solves the issue and prevents an unnecessary conversion from torch to numpy

  • Fixes a typo

@stefaanhessmann stefaanhessmann requested a review from jnsLs August 28, 2024 09:08
@jnsLs jnsLs merged commit ea056c6 into master Aug 28, 2024
2 checks passed
@jnsLs jnsLs deleted the sh/fix_so3 branch August 28, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants