Upgraded Autofac to 5.1

[pcherpitel]

Upgraded Service Fabric packages to 7.0.466
Dropped support for .Net 4.5
Upgraded package template (icon and license)

[pcherpitel]

@alexmg @tillig the changes are pretty straight forward since it's mostly nuget packages updates let me know what you think about it and if you would like some changes before I publish the PR.

[alexmg]

Looks good @pcherpitel. A few small tweaks and it's good to go!

[pcherpitel]

@alexmg @tillig Can you link the PR to #52 ?

[alsami]

Just as an info we need to finish this PR ahead of this since Autofac.ServiceFabric relies on Autofac.Extras.DynamicProxies.

[pcherpitel]

Just as an info we need to finish this PR ahead of this since Autofac.ServiceFabric relies on Autofac.Extras.DynamicProxies.

From what I understand the issue in Autofac.Extras.DynamicProxies affect interface interceptors which are not used in Autofac.ServiceFabric. In this context since the changes in Autofac 5.0 are causing runtime failures if we use Autofac.ServiceFabric 2.2 can we move forward with this PR?
@tillig @alexmg @alsami

[tillig]

That's a good point, I don't see DynamicProxy as being referenced here. @alsami can you clarify before we move forward here?

[alsami]

I am not a hundred percent sure, if going forward without the fix of DynamicProxy is safe. I would wait for the fix to be merged and then update this PR accordingly. Maybe users end up using that functionality in their project anyway because it's a transitive dependency. If it's save to go on without the fix then consider my comment obsolet :)

[tillig]

Oh, oh, oh, I see it now. There is a reference to Autofac.Extras.DynamicProxy. The diff had it hidden from me. I agree, we need to finish that one first so we can update the reference here.

[pcherpitel]

Autofac.ServiceFabric is using Autofac.Extras.DynamicProxies but only for class interceptors which are not relying on ActivatingHandlers so they are not impacted by the changes of Autofac 5.0. Autofac.Extras.DynamicProxies interface interceptors are definitely impacted by the changes of Autofac 5.0 because they rely on ActivatingHandlers and since this PR autofac/Autofac#1043 was merged back ActivatingHandlers can be called twice.
The current situation is just a bit frustrating because nothing prevent users of Autofac.ServiceFabric to update to Autofac 5.0 then they end up with runtime failure. Letting the PR go through will at least limit the impact to users that are using Autofac.Extras.DynamicProxies with interface interceptors.

[alsami]

The current situation is just a bit frustrating because nothing prevent users of Autofac.ServiceFabric to update to Autofac 5.0 then they end up with runtime failure.

We very much understand that this is frustrating and causes users to have problems. Which is why we need to make sure that we don't create more possible problems. We are working on the fix and as soon as that is done, we will get your PR ready and merge it 👍

[alexmg]

The other PR has been unblocked now.

[tillig]

Awesome! I'll probably increment this to 3.0.0 before publishing since Autofac 5 brings some breaking changes, but I should get it out the door shortly.