-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent workflow double trigger, Add PEP 561 compliance #1348
Conversation
eddiebergman
commented
Dec 15, 2021
•
edited
Loading
edited
- Adds windows and mac to the unit tests but they are currently deactivate
- Removes duplicate triggers of tests with pull and push requests for other workflows.
- Fixes check for PEP 561 compliance with the dist
- Adds PEP 561 compliance (which I thought was there already but was not)
Codecov Report
@@ Coverage Diff @@
## development #1348 +/- ##
===============================================
- Coverage 88.02% 87.85% -0.18%
===============================================
Files 140 140
Lines 10973 10959 -14
===============================================
- Hits 9659 9628 -31
- Misses 1314 1331 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a very nice simplification of the workflows. I only have one small question.
* update workflow files * typo fix * Update pytest * remove bad semi-colon * Fix test runner command * Remove explicit steps required from older version * Explicitly add Conda python to path for subprocess command in test * Fix the mypy compliance check * Added PEP 561 compliance * Add py.typed to MANIFEST for dist * Remove py.typed from setup.py
* update workflow files * typo fix * Update pytest * remove bad semi-colon * Fix test runner command * Remove explicit steps required from older version * Explicitly add Conda python to path for subprocess command in test * Fix the mypy compliance check * Added PEP 561 compliance * Add py.typed to MANIFEST for dist * Remove py.typed from setup.py