Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent workflow double trigger, Add PEP 561 compliance #1348

Merged
merged 11 commits into from
Dec 21, 2021

Conversation

eddiebergman
Copy link
Contributor

@eddiebergman eddiebergman commented Dec 15, 2021

  • Adds windows and mac to the unit tests but they are currently deactivate
  • Removes duplicate triggers of tests with pull and push requests for other workflows.
  • Fixes check for PEP 561 compliance with the dist
  • Adds PEP 561 compliance (which I thought was there already but was not)

@eddiebergman eddiebergman requested a review from mfeurer December 15, 2021 16:33
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1348 (79664b0) into development (887bb10) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1348      +/-   ##
===============================================
- Coverage        88.02%   87.85%   -0.18%     
===============================================
  Files              140      140              
  Lines            10973    10959      -14     
===============================================
- Hits              9659     9628      -31     
- Misses            1314     1331      +17     
Impacted Files Coverage Δ
...eline/components/feature_preprocessing/fast_ica.py 91.30% <0.00%> (-6.53%) ⬇️
...learn/pipeline/components/regression/libsvm_svr.py 85.22% <0.00%> (-5.69%) ⬇️
autosklearn/util/single_thread_client.py 90.90% <0.00%> (-2.28%) ⬇️
...ipeline/components/regression/gradient_boosting.py 91.42% <0.00%> (-1.97%) ⬇️
autosklearn/util/logging_.py 89.18% <0.00%> (-1.16%) ⬇️
...tosklearn/metalearning/metafeatures/metafeature.py 61.00% <0.00%> (-1.14%) ⬇️
autosklearn/ensemble_builder.py 85.85% <0.00%> (-0.99%) ⬇️
autosklearn/pipeline/components/base.py 78.78% <0.00%> (-0.26%) ⬇️
...sklearn/pipeline/components/regression/__init__.py 83.52% <0.00%> (-0.20%) ⬇️
...arn/pipeline/components/classification/__init__.py 84.94% <0.00%> (-0.17%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887bb10...79664b0. Read the comment docs.

@eddiebergman eddiebergman changed the title Add windows/mac to unit tests Prevent workflow double trigger, Add PEP 561 compliance Dec 16, 2021
Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a very nice simplification of the workflows. I only have one small question.

@eddiebergman eddiebergman merged commit aed6758 into development Dec 21, 2021
@eddiebergman eddiebergman deleted the cleanup_workflow_triggers branch December 21, 2021 13:41
@eddiebergman eddiebergman mentioned this pull request Jan 24, 2022
eddiebergman added a commit that referenced this pull request Jan 25, 2022
* update workflow files

* typo fix

* Update pytest

* remove bad semi-colon

* Fix test runner command

* Remove explicit steps required from older version

* Explicitly add Conda python to path for subprocess command in test

* Fix the mypy compliance check

* Added PEP 561 compliance

* Add py.typed to MANIFEST for dist

* Remove py.typed from setup.py
@eddiebergman eddiebergman mentioned this pull request Jan 25, 2022
eddiebergman added a commit that referenced this pull request Aug 18, 2022
* update workflow files

* typo fix

* Update pytest

* remove bad semi-colon

* Fix test runner command

* Remove explicit steps required from older version

* Explicitly add Conda python to path for subprocess command in test

* Fix the mypy compliance check

* Added PEP 561 compliance

* Add py.typed to MANIFEST for dist

* Remove py.typed from setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants