Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clang-tidy): add clang tidy pr comments #334

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions clang-tidy/action.yaml
Original file line number Diff line number Diff line change
@@ -113,7 +113,7 @@
if [ "${{ inputs.target-files }}" != "" ]; then
target_files="${{ inputs.target-files }}"
else
mapfile -t package_paths < <(colcon list --paths-only --packages-select ${{ inputs.target-packages }})

Check warning on line 116 in clang-tidy/action.yaml

GitHub Actions / spell-check-differential

Unknown word (mapfile)
ignore_patterns=()
ignore_patterns+=( -not -path "*/test/*" )
if [ -f ${{ inputs.clang-tidy-ignore-path }} ]; then
@@ -158,6 +158,20 @@
with:
files: /tmp/clang-tidy-result/fixes.yaml

- name: Copy fixes.yaml to access from Docker Container Action
if: ${{ steps.check-fixes-yaml-existence.outputs.exists == 'true' }}
run: |
cp /tmp/clang-tidy-result/fixes.yaml fixes.yaml
shell: bash

- name: Run clang-tidy-pr-comments action
if: ${{ steps.check-fixes-yaml-existence.outputs.exists == 'true' }}
uses: platisd/[email protected]
with:
github_token: ${{ inputs.token }}
clang_tidy_fixes: fixes.yaml
repo_path_prefix: "/__w" # yamllint disable-line

- name: Upload artifacts
if: ${{ steps.check-report-log-existence.outputs.exists == 'true' && steps.check-fixes-yaml-existence.outputs.exists == 'true' }}
uses: actions/upload-artifact@v4

Unchanged files with check annotations Beta

mkdocs-static-i18n
mkdocs-video
mike
pathspec

Check warning on line 13 in deploy-docs/mkdocs-requirements.txt

GitHub Actions / spell-check-differential

Unknown word (pathspec)
plantuml-markdown
pymdown-extensions
python-markdown-math