Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: porting autoware_trajectory from autoware.universe to autoware.core #186

Conversation

sasakisasaki
Copy link
Contributor

@sasakisasaki sasakisasaki commented Feb 13, 2025

Description

This PR is for porting a module from autoware.universe/common/autoware_trajectory to autoware.core/common/autoware_trajectory

WARNING: This PR MUST BE MERGED BY FOLLOWING STEPS:

  • Ensure the tests on the evaluator succeed except some scenarios (around 10)
  • Merge the both this PR and autoware.universe side PR at the same time

Related links

How was this PR tested?

autoware.universe side

Ongoing

autoware.core side

mkdir src
vcs import src < build_depends.repos
rosdep install -y --from-paths . --ignore-src --rosdistro $ROS_DISTRO
colcon build --base-paths . --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release

Notes for reviewers

Please do not approve until the preparation for merge is not done yet.

Interface changes

None.

Effects on system behavior

The autoware_trajectory is no longer available from the autoware.universe, but available via autoware.core

  * As this is initially ported from the different repository,
    it would (might) be better to apply this change.

Signed-off-by: Junya Sasaki <[email protected]>
Copy link

github-actions bot commented Feb 13, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sasakisasaki
Copy link
Contributor Author

@sasakisasaki
Copy link
Contributor Author

As this PR has some files which are not updated ones due to my mistake, I re-created a PR here. Let me close this PR.
#188

mitsudome-r pushed a commit to autowarefoundation/autoware.universe that referenced this pull request Feb 14, 2025
porting(autoware_trajectory): port to `autoware.core/common`

  * Related PR:
      autowarefoundation/autoware.core#186

Signed-off-by: Junya Sasaki <[email protected]>
yhisaki pushed a commit to tier4/autoware.universe that referenced this pull request Feb 25, 2025
…oundation#10113)

porting(autoware_trajectory): port to `autoware.core/common`

  * Related PR:
      autowarefoundation/autoware.core#186

Signed-off-by: Junya Sasaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant