docs: update README #36
Conversation
There was a problem hiding this comment.
Initial review. If people can spare the time, I would appreciate feedback around the first suggested change, along with the idea of adding an explanation to explain the current situation (developing bus ODD in Universe, will move over to Core at a later point). 🙇🏾
shmpwk
force-pushed
the
docs/update-README
branch
2 times, most recently
from
7185679 to
9547354
Compare
|
Is it okay if there is no explanation about the transition plan? I guess people would wonder why this repository is empty. |
|
Right, add porting plan by 682af3d. |
There was a problem hiding this comment.
LGTM. @mitsudome-r @xmfcx @BonoloAWF Could you briefly take a look at this, please? 🙏
There was a problem hiding this comment.
An Autoware repository that contains a basic set of high-quality, stable ROS packages for autonomous driving.
It is worthwhile adding one or two sentences explaining how this autoware.core repository relates to autoware.universe repository
|
@BonoloAWF |
|
@LalithVipulananthan @mitsudome-r @xmfcx @BonoloAWF Could I merge this? If I can get one more approval, I'd like to merge this. |
|
@shmpwk Apologies for missing this. I did want to rearrange some of the content in this README. If you can wait just a short while, I will review with my suggested changes before 5pm today. |
There was a problem hiding this comment.
LGTM, although unfortunately I do not have write access for this repo. @kenji-miyake, could you approve this PR again please?
Signed-off-by: Shumpei Wakabayashi <[email protected]>
Co-authored-by: Lalith Vipulananthan <[email protected]> Signed-off-by: Shumpei Wakabayashi <[email protected]>
Co-authored-by: Lalith Vipulananthan <[email protected]> Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: Shumpei Wakabayashi <[email protected]>
Co-authored-by: Lalith Vipulananthan <[email protected]> Signed-off-by: Shumpei Wakabayashi <[email protected]>
Co-authored-by: Lalith Vipulananthan <[email protected]> Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: Shumpei Wakabayashi <[email protected]>
updates: - [github.com/pre-commit/pre-commit-hooks: v4.2.0 → v4.3.0](pre-commit/pre-commit-hooks@v4.2.0...v4.3.0) - [github.com/scop/pre-commit-shfmt: v3.5.0-1 → v3.5.1-1](scop/pre-commit-shfmt@v3.5.0-1...v3.5.1-1) - [github.com/pre-commit/mirrors-clang-format: v14.0.3 → v14.0.4-1](pre-commit/mirrors-clang-format@v14.0.3...v14.0.4-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Shumpei Wakabayashi <[email protected]>
shmpwk
force-pushed
the
docs/update-README
branch
from
4bf10f3 to
a9d25a0
Compare
|
Thank you! Could you merge this @kenji-miyake since I don't have right to merge this. |
Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]>
Signed-off-by: Shumpei Wakabayashi [email protected]
Description
Update README with more concrete information.
Related PR: autowarefoundation/autoware.universe#970 (comment)
The README explanation is based on https://github.com/autowarefoundation/autoware which says
I mainly changed the 2nd line because IMO
The universe explanation is based on https://github.com/autowarefoundation/autoware.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.