-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(vehicle_constants_manager)!: remove package #2232
refactor(vehicle_constants_manager)!: remove package #2232
Conversation
Signed-off-by: Takayuki Murooka <[email protected]>
@xmfcx Can I remove this package? |
Sure, I've created this package in Autoware.Auto as a mirror of |
@kenji-miyake why is this job giving following error?
It seems ok to me 🤔 |
Oh it was just the space character before the colon 😮 |
@xmfcx Thank you. Regarding failed job, there is unnecessary space since we cannot put "!" with |
…ion#2232) refactor(vehicle_constants_manager)! : remove package Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
…ion#2232) refactor(vehicle_constants_manager)! : remove package Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: yoshiri <[email protected]>
Signed-off-by: Takayuki Murooka [email protected]
Description
Since we have vehicle_info_util widely used in autwoare.universe, the almost same package (vehicle_constants_manager) is not needed.
https://github.com/autowarefoundation/autoware.universe/tree/main/vehicle/vehicle_info_util/
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.