Add findTestHelpers() to find helpers and fixtures #8
Conversation
vadimdemedes
force-pushed
the
find-test-helpers
branch
from
e63accf to
21e16f2
Compare
| @@ -30,6 +30,10 @@ avaFiles.isSource(filePath); | |||
| avaFiles.findTestFiles().then(files => { | |||
| // files is an array of found test files | |||
| }); | |||
|
|
|||
| avaFiles.findTestHelpers().then(files => { | |||
| // files is an array of found test helpers and fixtures | |||
There was a problem hiding this comment.
I'd argue that fixtures are different from helpers.
There was a problem hiding this comment.
From the point of this method's functionality of precompiling code, they're the same. Are you referring to the function name or comment?
| return files.filter(function (file) { | ||
| return multimatch([file], [ | ||
| '**/fixtures/**', | ||
| '**/helpers/**' |
There was a problem hiding this comment.
Helpers may also start with an underscore.
| symlinks: Object.create(null) | ||
| }).then(function (files) { | ||
| return files.filter(function (file) { | ||
| return multimatch([file], [ |
There was a problem hiding this comment.
Why not just pass files directly to multimatch?
| 'test/fixtures/foo-fixt.js', | ||
| 'test/helpers/test.js' | ||
| ].map(function (file) { | ||
| return path.join(fixtureDir, file); |
There was a problem hiding this comment.
Use inline arrow function.
There was a problem hiding this comment.
Shouldn't it be compatible with older Node.js versions?
There was a problem hiding this comment.
@vdemedes This is the test though, run through Babel with AVA.
There was a problem hiding this comment.
Oh, I confused this with the other thing, nvm.
vadimdemedes
force-pushed
the
find-test-helpers
branch
from
21e16f2 to
111ecde
Compare
|
Updated PR according to all the feedback, thanks guys! |
|
LGTM. @novemberborn ? |
Used by avajs/ava#1078, so that we can precompile helpers and fixtures as well.