Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack traces for input source maps #273

Merged
merged 2 commits into from
Nov 26, 2015
Merged

Stack traces for input source maps #273

merged 2 commits into from
Nov 26, 2015

Conversation

novemberborn
Copy link
Member

Follow-up to #262, as requested by @jamestalmage:

Can we also make sure we are covering the case where the test file itself may have a source map?


Note the second commit which is unrelated to input source map support but removes an unnecessary stringification of the transpiled source map.

Compute correct stack traces if the test file itself was already compiled before
ava was run, provided it contains a source map pragma.
source-map-support works fine if the map is already an object.
@sindresorhus
Copy link
Member

Looks good to me. @jamestalmage ?

@jamestalmage
Copy link
Contributor

👍

Note the second commit which is unrelated to input source map support but removes an unnecessary stringification of the transpiled source map

Bah! I meant to fix that. Thanks @novemberborn.

jamestalmage added a commit that referenced this pull request Nov 26, 2015
…cemaps

Stack traces for input source maps
@jamestalmage jamestalmage merged commit 84fb575 into avajs:master Nov 26, 2015
@novemberborn novemberborn deleted the stack-traces-for-input-sourcemaps branch November 26, 2015 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants