Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Node.js v4.x and v5.x #388

Merged
merged 1 commit into from
Dec 29, 2015
Merged

Test on Node.js v4.x and v5.x #388

merged 1 commit into from
Dec 29, 2015

Conversation

ntwb
Copy link
Contributor

@ntwb ntwb commented Dec 29, 2015

No description provided.

@vadimdemedes
Copy link
Contributor

nvm install stable installs latest stable Node.js version:

screen shot 2015-12-29 at 3 53 34 pm

@ntwb
Copy link
Contributor Author

ntwb commented Dec 29, 2015

The latest stable is NodeJS v5.3.0 https://nodejs.org/en/

Travis needs to update their docs, but here on the NVM #Usage section of the docs its documented about the stable alias being deprecated.

In nvm-sh/nvm#870 there is a discussion about future aliases such as LTS, and other options...

@ntwb
Copy link
Contributor Author

ntwb commented Dec 29, 2015

Using 4 and 5 per the pull request will use NVM to always test the latest 4.x.x (currently 4.2.4) and 5.x.x (currently 5.3.0) version/branches respectively so until NodeJS v6 is out things should be right here for a while 😏

Also see sindresorhus/grunt-sass#263 and @sindresorhus 👍 for these changes

@vadimdemedes
Copy link
Contributor

Node.js stable releases are even numbers, so 5.3.0 is not a stable release.

I just talked to @sindresorhus and we agreed to test for 4.x too as it is LTS release. I'll accept all your PRs now, thanks ;)

@vadimdemedes vadimdemedes reopened this Dec 29, 2015
@sindresorhus
Copy link
Member

Node.js stable releases are even numbers, so 5.3.0 is not a stable release.

Not exactly true. All major versions are stable, it's just the even ones are LTS releases. https://nodejs.org/en/blog/community/node-v5/

@vadimdemedes
Copy link
Contributor

@sindresorhus correcting myself, Node.js stable releases are even minor numbers.

@vadimdemedes
Copy link
Contributor

Oh ok, I should update myself on release cycles.

@vadimdemedes vadimdemedes changed the title Travis CI: Switch from deprecated stable NodeJS to versions 4.x.x & 5.x.x Test on Node.js v4.x and v5.x Dec 29, 2015
vadimdemedes pushed a commit that referenced this pull request Dec 29, 2015
Test on Node.js v4.x and v5.x
@vadimdemedes vadimdemedes merged commit b83e4f5 into avajs:master Dec 29, 2015
@ntwb
Copy link
Contributor Author

ntwb commented Dec 29, 2015

Yep, clear as mud all of this isn't it 😏

I started down the road of updating WordPress' NPM dependencies and basically sending pull requests everywhere so that firstly the current stable versions of NodeJS are at least being tested in Travis CI, once thats done I can then look at updating any tests and/or dependencies :)

@ntwb ntwb deleted the patch-1 branch December 29, 2015 14:19
@ntwb
Copy link
Contributor Author

ntwb commented Dec 29, 2015

Thanks for merging, and all that jazz 👍

@vadimdemedes
Copy link
Contributor

@ntwb Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants