Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests that demonstrate various ways to use babel config. #706

Merged
merged 1 commit into from
Apr 5, 2016

Conversation

jamestalmage
Copy link
Contributor

Issue #448 was kept open, in part, because we wanted to enable an extends option.
What we are after is actually possible using existing babel options.

A separate PR with recipes is forthcoming.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @spudly, @sotojuan and @ariporad to be potential reviewers

@@ -5,7 +5,7 @@ var figures = require('figures');
var rimraf = require('rimraf');
var test = require('tap').test;
var Api = require('../api');
var testDoublerPlugin = require('./fixture/babel-plugin-test-doubler');
var testCapitilizerPlugin = require('./fixture/babel-plugin-test-capitilizer');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalizer

@novemberborn
Copy link
Member

Just that typo. LGTM otherwise.

@sindresorhus
Copy link
Member

LGTM

@jamestalmage jamestalmage force-pushed the add-babelrc-tests branch 2 times, most recently from 86e1542 to 9288d78 Compare April 5, 2016 21:57
@jamestalmage jamestalmage merged commit 9288d78 into avajs:master Apr 5, 2016
@jamestalmage jamestalmage deleted the add-babelrc-tests branch April 6, 2016 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants