Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigInt support? #146

Closed
danielberndt opened this issue Feb 10, 2022 · 2 comments · Fixed by #160
Closed

BigInt support? #146

danielberndt opened this issue Feb 10, 2022 · 2 comments · Fixed by #160

Comments

@danielberndt
Copy link

Passing a BigInt to filesize causes an exception (in Chrome 98, but it's probably the same in all other envs too):

Uncaught TypeError: Cannot convert a BigInt value to a number
at isNaN ()

Given that BigInt is widely supported these days it could make sense for this library to also support it as an input.

Curious about your thoughts!
@avoidwork
Copy link
Owner

sounds good to me.

avoidwork added a commit that referenced this issue Sep 28, 2022
@avoidwork
Adding support for BigInt numbers, fixes #146
80ef95c
@avoidwork avoidwork mentioned this issue Sep 28, 2022
Merged
6 tasks
@avoidwork
Copy link
Owner

This is 10.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BigInts and named exports avoidwork/filesize.js
2 participants
@avoidwork @danielberndt