- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in tests and examples #72
Comments
You're welcome to change it with a PR. |
The website is also 2-3yr out of date, please include updates there too. |
Ok, I'll change values in examples to what is actually returned. |
The example on the site is loaded with gist https://gist.github.com/4698968.js |
tests from main page of http://filesizejs.com/ Some are not correct, see avoidwork/filesize.js#72
It was outdated. See avoidwork/filesize.js#72
I'm trying to reimplement it in Lua: https://github.com/starius/lua-filesize |
Ah, well I guess that's unfortunate timing; all of the tests were corrected for JEDEC/SI, because it used to be SI centric. |
https://github.com/avoidwork/filesize.js/blob/f7a059f/test/filesize_test.js#L22
https://github.com/avoidwork/filesize.js/blob/f7a059f/README.md
Discrepancies:
See also #69
The text was updated successfully, but these errors were encountered: