Replace build system with rollup #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avoidwork Can you take a look a this PR? 🙏 |
|
@realityking thanks a lot for taking care of this! shipped as 6.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes the changes from #121.
This PR replaces
gruntwith a with package scripts based build system. The same version of thenodeunit-xandeslintare used, those upgrades can be handled later separately.More importantly, this PR changes the build tool to
rollup. Right nowrollupis configured to create exactly the same files as they're currently shipping but with a tiny size saving (lib/filesize.es6.min.jsis 12 bytes smaller). However rollup has a lot of potential to ship more efficient builds using CommonJS and ESM that I'd like to propose in a follow-up PR.Fixes #123
Fixes #124