[feature suggestion] add roundingMethod option #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea, thanks! |
|
This is 6.3.0 👍🏻 |
|
Thank you for your quick response! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings, first I want to thank you for providing this useful library. This PR is a feature suggestion to make it even more useful for us and hopefully for others as well.
This PR is aiming to add an option
roundingMethod, which allows you to round the number not only byround, but alsofloororceil. This came out of an actual business requirement we got, "never show the capacity more than actually available to the user", where rounding up could be a problem hence we need to usefloor.I hope you find this useful and worth to be merged. I tried to follow the style convention of the existing code, but please feel free to tell me if I am missing anything. Thank you very much and have a great day!