Make SI and IEC standards defaults #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the SI standard (base 10) the generic default, and the IEC standard the default for base-2 formatting in order to make it as intuitive as possible, to reduce any ambiguity, and to mirror the industry standard. Fixes avoidwork#137
|
@getsnoopy I don't want to make SI default; just IEC if you feel it needs to change. There's millions of projects using this directly and indirectly, and base 2 to 10 would impact them. |
|
merged it anyways, 'cause this should happen (aka 2.0.0). |
|
This would be a major version bump, so no one currently using this would be affected by it; only new users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the SI standard (base 10) the generic default, and the
IEC standard the default for base-2 formatting in order to make it as
intuitive as possible, to reduce any ambiguity, and to mirror the
industry standard.
Fixes #137