Fixing base 2 jedec regression with refactoring #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
avoidwork
commented
Jun 27, 2022
•
avoidwork
commented
- Adding dupe set of base2 tests explicitly set to jedec standard to expose logic error
- Fixing the conditional statement which assigns standard if base has been specified
- Fixes filesize(1024, { base: 2, standard: 'jedec' }) does not return 1 KB #156
…o expose logic error
…as been specified, updating `bit` tests in `base2Jedec` set Reducing change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.