chore: switch from travis to gh actions (fixes #169) #170
Conversation
|
Huge thanks for this. Do you want to merge that already and iterate with new PRs for the fixes or want to play whack a mole for a few iterations? |
|
Should this also include a change in README.md to remove the travis reference? |
|
The issue is more that Travis removed itself. They switched off all open source projects free accounts once they consumed some "credits". I paid for the commercial version for 6months until amazing people helped to move the main repo to GitHub actions. I knew when I stopped paying it would break the |
|
i think it's ready now |
|
now gon be the most interesting part 😹 |
|
apparently it needs token to be set in secrets? |
|
and also it doesn't show the commit range correctly🙁 : https://github.com/awesomeWM/awesome-www/runs/7063206869?check_suite_focus=true#step:14:35 |
|
I gave you the rights to manage the secrets for |
|
no, i don't (neither for /awesome/ repo itself) |
|
you really should. Maybe it sent you an email with an invite link?
|
|
Anyway, if for whatever reason its broken, give me instructions and I will try to set them. |
|
now i can see the secrets for www repo, but not for the main one i need to copy the same secret from https://github.com/awesomeWM/awesome/settings/secrets/actions to https://github.com/awesomeWM/awesome-www/settings/secrets/actions |
|
(i guess key itself should be somewhere in the settings of this repo, but i can't view them neither: https://github.com/awesomeWM/awesomeWM.github.io) |
|
The |
|
yup |
|
the key i think should be at https://github.com/awesomeWM/awesomeWM.github.io/settings/keys |
|
@blueyed Can you add it to |
|
i think you can just add a new key there as well if you can't view existing one: https://github.com/awesomeWM/awesomeWM.github.io/settings/keys |
|
I think it in a normal github account, not the project one ( https://github.com/awesome-robot ). I don't control that account. Let's wait a couple days and see if Daniel replies. |
|
no, i mean you can use just a deployment key frmo there: https://github.com/awesomeWM/awesomeWM.github.io/settings/keys |
|
(with write access) |
|
Right now there isn't any. I am pretty sure it was just using the robot account so far. Is it worth changing that? |
|
i think it shouldn't be much difference - as you sharing that token only with github, not with some additional third-parties like travis |
|
Ok, go ahead, I made you admin of awesomeWM.github.io |
|
my bad, i tried - it allowing to generate only ssh key but not the token :( |
|
i could generate a token from my own account in order just to test all ci step work |
|
(and after testing remove the token and wait next for @blueyed to put the correct token instead of it) |
|
As a temporary solution maybe. Long term we need to find a way to manage the robot account in a way that doesn't involve a single point of failure. But right now, getting -www to work again is worth a few hacks. It being broken is a rather big problem and I am glad you are taking upon fixing that, so go ahead. |
|
now it works (i removed my personal token, so it just empty string now) also somebody would need to set: $CLOUDFLARE_ZONE $CLOUDFLARE_AUTH_EMAIL $CLOUDFLARE_AUTH_KEY |
No description provided.