Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme to reflect Codeql-Action-v1 deprecation #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thomastu
Copy link

https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/

Issue #, if available:

Description of changes:

  • Updated readme setup to reference github/codeql-action/upload-sarif@v2 since v1 has been deprecated and now leads to build errors.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ceberttylertech
Copy link

Is CodeGuru Reviewer essentially dead?

@dejonghe
Copy link

@thomastu nice work, came here to do the same.... Spent some time on AWS support about trying to use this and they were useless. Their own docs are also out of date, in the AWS docs it tells the user to use aws creds v1 when they're on v4, and for some dumb reason they removed the ability to update the docs through GitHub pull requests, which they had put in place because they cant keep up with their own docs, but now us as consumers can't even help and have to trouble shoot services we're paying for.... Get it together AWS, quit laying off your engineers.

@dejonghe
Copy link

@ceberttylertech I was hoping to be able to post something was working but after updating action versions for both aws and codeql, attempting to update permissions etc... this project def seems 💀
If you got it working let me know but after a couple hours... I'm cutting bait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants