fix: use of GITHUB_ACTIONS flag instead of GITHUB_ACTION #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauln
changed the title
…ole functionality
sauln
force-pushed
the
sauln/fix-github-action-env-var
branch
from
639c2b1 to
c7bd6e7
Compare
AnthonyP613
approved these changes
Aug 4, 2020
edwaltz89
approved these changes
Aug 4, 2020
|
I'd suggest, following official comments from staff @ Github related to a bug in runner (that is expected to be rolled out in under 1 hr), this PR is now superfluous. see: https://github.community/t/github-action-environment-variable-missing-breaking-issue/125913 |
|
I’m glad they’ll be resolving it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #105
Description of changes:
Looks like github actions made some changes with the
GITHUB_ACTIONenvironment variable and it's set off a whole slew of problems for many gh-actions.actions/runner/issues/635
A fix in codecov/codecov-bash/pull/341 suggests that the
GITHUB_ACTIONSflag is still functioning correctly. Since theGITHUB_ACTIONenvironment variable is used to generate the session tags, I assume just having the boolean will be sufficient.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.