Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update GHES hostname #1258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: update GHES hostname #1258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c92873
Update GHES hostname
brant4test Jan 19, 2025
075dca2
Merge branch 'main' into patch-1
brant4test Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,12 @@ Outputs:
Value: !GetAtt Role.Arn
```

For GHES, please replace the following three places:

Change the Url of GithubOidc from https://token.actions.githubusercontent.com to your GitHub Enterprise Server hostname https://<GHES_hostname>/_services/token.

Additionally, replace token.actions.githubusercontent.com in both StringEquals and StringLike with <GHES_hostname>.

### Claims and scoping permissions
To align with the Amazon IAM best practice of [granting least
privilege](https://docs.aws.amazon.com/IAM/latest/UserGuide/best-practices.html#grant-least-privilege),
Expand Down