-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test) - Reduce dependency on AWS config file #201
fix(test) - Reduce dependency on AWS config file #201
Conversation
83ac371
to
fccaa23
Compare
Waiting on #202 |
Cross referencing this issue I raised with boto3 as I don't believe the |
If no ~/.aws/config file exists
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d05021b
to
66dc84d
Compare
66dc84d
to
9aa2b7e
Compare
|
||
stubber.add_client_error("put_metric_data", "InternalServiceError") | ||
stubber.activate() | ||
client = mock_session.client("cloudwatch") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
big fan of stubber but haven't gotten it working with the mocked session. This also brings more consistency as these are the only tests using stubber.
Issue #, if available:
Description of changes:
~/.aws/config
when doing mocks. This PR will completely remove that dependency.You will have issues with the current version of the tests if you have no
~/.aws/config
or are using thecredential_process
attribute in a profileBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.