-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: missing classtransformer upgrade and proper model types #129
base: master
Are you sure you want to change the base?
bugfix: missing classtransformer upgrade and proper model types #129
Conversation
@kddejong Heyo, just packaged the python part and tested it and all good. Looks like the unit test issue is on the loggerproxy. I can't replicate it on my end, but I'm using an M3 |
I think #130 should fix it. |
oh hahaha I just did the same thing |
@HeatherFlux there is one more fix you will need for the macOS builds in that PR. Then I can close my PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 98.47% 97.97% -0.51%
==========================================
Files 14 14
Lines 1249 1281 +32
Branches 213 244 +31
==========================================
+ Hits 1230 1255 +25
- Misses 17 24 +7
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Should be all good now |
@kddejong any update on this getting merged? |
I've just updated |
I reverted the colima change that @kddejong had put in. If this gets merged it will fix the plugin for all TS developers |
Last time I had to ping our AWS TAM to get some movement. You might want to ping your TAM as well. |
@ericzbeard Looks like all the CI's are deprecated |
@HeatherFlux can you make the change to the workflow? |
@ericzbeard updated |
Issue ARCH-1058
Description of changes:
Updating the template for the model to conform to the new type coming from class transformer as well as the codegen and package.json templates to match the new versions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.