Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: missing classtransformer upgrade and proper model types #129

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

HeatherFlux
Copy link

Issue ARCH-1058

Description of changes:

Updating the template for the model to conform to the new type coming from class transformer as well as the codegen and package.json templates to match the new versions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HeatherFlux
Copy link
Author

HeatherFlux commented Aug 15, 2024

@kddejong Heyo, just packaged the python part and tested it and all good. Looks like the unit test issue is on the loggerproxy.

I can't replicate it on my end, but I'm using an M3

@kddejong
Copy link
Contributor

I think #130 should fix it.

@HeatherFlux
Copy link
Author

I think #130 should fix it.

oh hahaha I just did the same thing

@kddejong
Copy link
Contributor

@HeatherFlux there is one more fix you will need for the macOS builds in that PR. Then I can close my PR

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (115b7c0) to head (b3e34be).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   98.47%   97.97%   -0.51%     
==========================================
  Files          14       14              
  Lines        1249     1281      +32     
  Branches      213      244      +31     
==========================================
+ Hits         1230     1255      +25     
- Misses         17       24       +7     
  Partials        2        2              
Flag Coverage Δ
unittests 97.97% <100.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HeatherFlux
Copy link
Author

Should be all good now

@HeatherFlux
Copy link
Author

@kddejong any update on this getting merged?

@HeatherFlux
Copy link
Author

@akash1810
Copy link

I've just updated @amazon-web-services-cloudformation/cloudformation-cli-typescript-lib to v1.0.6 and witnessed this issue. Do we know if the repository is still active? What's the best way to get this merged and a new version released? For now, I've pinned to v1.0.5 and configured Dependabot to ignore this dependency.

@HeatherFlux
Copy link
Author

I reverted the colima change that @kddejong had put in. If this gets merged it will fix the plugin for all TS developers

@HeatherFlux
Copy link
Author

@HeatherFlux
Copy link
Author

I've just updated @amazon-web-services-cloudformation/cloudformation-cli-typescript-lib to v1.0.6 and witnessed this issue. Do we know if the repository is still active? What's the best way to get this merged and a new version released? For now, I've pinned to v1.0.5 and configured Dependabot to ignore this dependency.

Last time I had to ping our AWS TAM to get some movement. You might want to ping your TAM as well.

@HeatherFlux
Copy link
Author

HeatherFlux commented Feb 24, 2025

@ericzbeard Looks like all the CI's are deprecated
:edit
the ones that are not deprecated did pass however.

@ericzbeard
Copy link

@HeatherFlux can you make the change to the workflow?

@HeatherFlux
Copy link
Author

@ericzbeard updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants