Pin k8s.io/{apimachinery|api|client-go} to v0.26.1
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses aws-controllers-k8s/community#1719 This patch updates `k8s.io/{apimachinery|api|client-go}` to `v0.26.1` and fixes the generated/usage of the mocks used for unit testing. Note that `controller-runtime/pkg/client/StatusWriter` is no longer declared probably, and is a copy of `SubResourceWriter` now. https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/client/interfaces.go#L132-L133 Changes to the mocks: - Brings and uses `SubResourceWriter` instead of `StatusWriter` - Removes `TestMetaV1ObjectEqual_ClusterName` (deprecated field) and test `TestMetaV1ObjectEqual_RemainingItemCount` instead - Get rid of unused mock files (`rm -rf ./mocks && make mocks`)
|
Tested with |
a-hilaly
added a commit
to a-hilaly/ack-code-generator
that referenced
this pull request
Mar 7, 2023
…time to `v0.14.5` Similarily to aws-controllers-k8s/runtime#119.. upgrading the k8s libraries versions.
jaypipes
approved these changes
Mar 7, 2023
| github.com/google/go-cmp v0.5.5 | ||
| github.com/cenkalti/backoff/v4 v4.1.3 | ||
| github.com/go-logr/logr v1.2.3 | ||
| github.com/google/go-cmp v0.5.9 |
There was a problem hiding this comment.
we really should not be using this lib... future PR to remove it would be good.
There was a problem hiding this comment.
google/go-cmp is used by apimachinery :/
jljaco
approved these changes
Mar 7, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, jljaco, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a-hilaly
added a commit
to aws-controllers-k8s/code-generator
that referenced
this pull request
Mar 7, 2023
…time to `v0.14.5` (#425) Similarily to aws-controllers-k8s/runtime#119.. upgrading the k8s libraries versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses aws-controllers-k8s/community#1719
This patch updates
k8s.io/{apimachinery|api|client-go}tov0.26.1and fixes the generated/usage of the mocks used for unit testing.
Note that
controller-runtime/pkg/client/StatusWriteris no longerdeclared properly, and is a copy of
SubResourceWriternow.Changes to the mocks:
SubResourceWriterinstead ofStatusWriterTestMetaV1ObjectEqual_ClusterName(deprecated field) andtest
TestMetaV1ObjectEqual_RemainingItemCountinsteadrm -rf ./mocks && make mocks)Changes to the go modules:
k8s.io/{apimachinery|api|client-go}tov0.26.1go mod tidyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.