Update dependencies and improve ACK runtime support #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
Quick sanity patch to keep things up-to-date:
- Upgraded `k8s/controller-runtime` to `v0.16.3`, which required changes
to some mocks and regeneration of mocks.
- Updated `k8s.io/{apimachinery,client-go,api}` to `v0.28.3`
- Updated `github.com/prometheus/client_golang` to `v1.16.0`
- Updated `github.com/go-logr/logr` to `v1.2.4`
- Updated `github.com/stretchr/testify` to `v1.8.2`
- Updated `github.com/cenkalti/backoff/v4` to `v4.2.1`
The k8s libraries updates help mainly in extending support for future
Kubernetes versions and reduce the chances of getting flagged for CVE
vulnerabilities.
Note: since this patch require mocks regeneration - we're also bumping
the `mockery` version to `v2.33.2`
Signed-off-by: Amine <[email protected]>
a-hilaly
force-pushed
the
sanity-updates
branch
from
0d3150e to
06a8c6a
Compare
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
acornett21
approved these changes
Jan 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, acornett21 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick sanity patch to keep things up-to-date:
k8s/controller-runtimetov0.16.3, which required changesto some mocks and regeneration of mocks.
k8s.io/{apimachinery,client-go,api}tov0.28.3github.lhy31512.workers.dev/prometheus/client_golangtov1.16.0github.lhy31512.workers.dev/go-logr/logrtov1.2.4github.lhy31512.workers.dev/stretchr/testifytov1.8.2github.lhy31512.workers.dev/cenkalti/backoff/v4tov4.2.1The k8s libraries updates help mainly in extending support for future
Kubernetes versions and reduce the chances of getting flagged for CVE
vulnerabilities.
Note: since this patch require mocks regeneration - we're also bumping
the
mockeryversion tov2.33.2Signed-off-by: Amine [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.