Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWSResourceManagerFactory to include roleARN paramter #156

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

a-hilaly
Copy link
Member

This patch modifies the AWSResourceManageFactory intgerface and
its implementation to include a roleARN parameter in the
ManagerFor function.

The addition of roleARN is necessary to support fine-grained
access control and multi-tenant scenarios where different IAM roles
may be used within the same AWS account and region. This change
corresponds to the updates in code-generaotr repository.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This patch modifies the `AWSResourceManageFactory` intgerface and
its implementation to include a `roleARN` parameter in the
`ManagerFor` function.

The addition of `roleARN` is necessary to support fine-grained
access control and multi-tenant scenarios where different IAM roles
may be used within the same AWS account and region. This change
corresponds to the updates in code-generaotr repository.
@ack-prow ack-prow bot requested a review from jlbutler August 12, 2024 06:57
@ack-prow ack-prow bot added the approved label Aug 12, 2024
Copy link

ack-prow bot commented Aug 12, 2024

@a-hilaly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
s3-controller-test 9fdb7f0 link true /test s3-controller-test
iam-controller-test 9fdb7f0 link true /test iam-controller-test
ecr-controller-test 9fdb7f0 link true /test ecr-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member Author

Tests are failling since this change also requires code-gen changes

Copy link

ack-prow bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, TiberiuGC

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TiberiuGC TiberiuGC merged commit a606fd1 into aws-controllers-k8s:main Aug 29, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants