Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double row matmul #49

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Double row matmul #49

wants to merge 5 commits into from

Conversation

aws-maxkoh
Copy link

@aws-maxkoh aws-maxkoh commented Feb 11, 2025 •
edited
Loading

Issue #, if available:

Description of changes:

  • Implement fp8_e4m3 double row matrix multiplication
  • Add unit tests

Testing:

Please see detailed unit test requirements in the CONTRIBUTING.md

  • The change is covered by numeric check using nki.baremetal
  • The change is covered by performance benchmark test using nki.benchmark
  • The change is covered by end-to-end integration test

Pull Request Checklist

  • I have filled in all the required field in the template
  • I have tested locally that all the tests pass
  • By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.

@aws-maxkoh aws-maxkoh requested a review from aws-zhehongb March 24, 2025 14:25
aws-zhehongb
aws-zhehongb previously approved these changes Mar 26, 2025
View reviewed changes
aws-qieqingy
aws-qieqingy previously approved these changes Mar 26, 2025
View reviewed changes
@aws-maxkoh aws-maxkoh dismissed stale reviews from aws-qieqingy and aws-zhehongb via 41753fb March 27, 2025 13:57
aws-qieqingy
aws-qieqingy previously approved these changes Mar 27, 2025
View reviewed changes
aws-zhehongb
aws-zhehongb previously approved these changes Mar 27, 2025
View reviewed changes
@aws-maxkoh aws-maxkoh dismissed stale reviews from aws-zhehongb and aws-qieqingy via f9223b7 March 27, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-zhehongb aws-zhehongb aws-zhehongb approved these changes

@aws-qieqingy aws-qieqingy aws-qieqingy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aws-maxkoh @aws-zhehongb @aws-qieqingy