-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotary Embedding NKI Kernel Tutorial #53
base: main
Are you sure you want to change the base?
Conversation
specify indicies for other dims when storing tiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot merge this at the moment. The source of the tutorial is now hosted in an internal location and is displayed at https://awsdocs-neuron.readthedocs-hosted.com/en/latest/general/nki/tutorials.html. All of the existing tutorial has a RTD file that is in a certain format. We plan to migrate the tutorial source code to this repo soon and then we can add the RST file for this tutorial as well.
Cannot merge for now due to reason stated in a separate comment.
""" | ||
# Rotate Q | ||
output_tile[0, :, :] = q_tile * cos_tile | ||
output_tile[0, :, : q_tile.shape[-1] // 2] = output_tile[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to assert q_tile.shape[-1] % 2 == 0
also could we assign q_tile.shape[-1]
to a temp variable such that we dont need to type q_tile.shape[-1]
repeatedly?
Issue #, if available:
N/A
Description of changes:
NKI kernel tutorial for applying rotary embedding to query, key tensors. Included benchmarking, and correctness tests with script
Testing:
Please see detailed unit test requirements in the CONTRIBUTING.md
nki.baremetal
nki.benchmark
Pull Request Checklist