Private cluster defect (always on) #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapirov103
requested review from
aws-ia-ci,
youngjeong46,
elamaran11 and
a team
as code owners
elamaran11
reviewed
Mar 4, 2025
examples/examples.ts
Outdated
| launchTemplate: { | ||
| requireImdsv2: true, | ||
| tags: { | ||
| "cost-center": "2122", |
There was a problem hiding this comment.
WHy is cost center required?
There was a problem hiding this comment.
not requited. it is an example of using LT tags
There was a problem hiding this comment.
ah ok. I think this should go to documentation too.
There was a problem hiding this comment.
we have docs on LT tags, but not example. I used to based on the defect brought up by the customer. I will eventually add docs for all examples in this repo. In general, we tend to use patterns repo for such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unable to create a cluster in the public subnets only
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.