Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CLI exampeles for EC2 and ECR #4876

Merged
merged 1 commit into from
Jan 28, 2020
Merged

New CLI exampeles for EC2 and ECR #4876

merged 1 commit into from
Jan 28, 2020

Conversation

bisdavid
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #4876 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4876      +/-   ##
===========================================
+ Coverage    93.93%   93.94%   +<.01%     
===========================================
  Files          189      189              
  Lines        14511    14524      +13     
===========================================
+ Hits         13631    13644      +13     
  Misses         880      880
Impacted Files Coverage Δ
awscli/customizations/ecr.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c98b0...32d4623. Read the comment docs.

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Just had a small comment related to a change we recently merged.


This example command gets an authorization token for your default registry and
returns the decoded password for you to use in a ``docker login`` command.
The following ``get-authorization-token`` example command gets an authorization token for your default registry and returns the decoded password for you to use in a ``docker login`` command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just today we added a new get-login-password command that essentially performs the logic for this example: #4874. I'm wondering if we should actually just remove example 2 and example 3 here and point people to use the new command instead? Using the get-login-password command is going to be the recommended pattern going forward.

@bisdavid
Copy link
Contributor Author

Got permission from the service writer to remove the two examples. At a later date, he'll submit an example for the new get-login-password command.

@jamesls jamesls merged commit de8f586 into aws:develop Jan 28, 2020
@bisdavid bisdavid deleted the awsdocs-01-24 branch March 3, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants