Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[customizations/eks]: Update credential API version" (#6309) #6310

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

nateprewitt
Copy link
Member

This moves the bug fix from #6309 onto v2 for the next AWS CLI v2 release.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #6310 (c0a4f09) into v2 (8205a0f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2    #6310   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         273      273           
  Lines       21691    21691           
=======================================
  Hits        20431    20431           
  Misses       1260     1260           
Impacted Files Coverage Δ
awscli/customizations/eks/get_token.py 100.00% <ø> (ø)
awscli/customizations/eks/update_kubeconfig.py 97.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8205a0f...c0a4f09. Read the comment docs.

@@ -2,7 +2,7 @@ users:
- name: arn:aws:eks:us-west-2:111222333444:cluster/Existing
user:
exec:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeffrey Gomez

@@ -16,7 +16,7 @@ users:
- name: arn:aws:eks:region:111222333444:cluster/ExampleCluster
user:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeffrey Gomez

@nateprewitt nateprewitt merged commit cf16bd0 into v2 Jul 30, 2021
@nateprewitt nateprewitt deleted the eks_v2 branch July 30, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants