-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing HandlerFunction to run
function directly
#20
Conversation
Hi @carlzogh, it seems you are the primary contributor on this repo. Are we able to get some feedback on this PR? We have some internal PRs that are blocked waiting on whether this PR will be merged or not. Thanks in advance! |
Thanks for your contribution @Ugzuzg! The approach looks good to me, this would also enable the NodeJS RIC to be run similarly to the GoLang RIC by passing a static reference to a function handler. Would you be able to add test coverage for |
445072a
to
e6c7c58
Compare
@carlzogh, I have added the tests as requested. |
e6c7c58
to
9f85619
Compare
@carlzogh, forgot to run |
9f85619
to
f34110d
Compare
@carlzogh, rebased on top of the latest changes from main branch. Can you please review? |
@carlzogh any update on this? thanks in advance! |
f34110d
to
b60c1ab
Compare
run
function directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @zsombor-balogh - many thanks for reviewing and merging! Are you able to release a new version of the library which includes the change, so we can start using it? |
It would be useful for us to be able to pass the handler function directly to the
run
export when using it programmatically, as we want to have our own RIC, which loads a handler that doesn't need to know about being inside lambda.