feat: add ability to drain on rebalance #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 |
brycahta
reviewed
Apr 7, 2021
brycahta
suggested changes
Apr 8, 2021
There was a problem hiding this comment.
Just remove version bump in Chart.yaml-- everything else looks good 👍
Were you able to confirm the sqs behavior from my previous comment:
- Is it necessary to set both
enableSqsTerminationDrainingandenableRebalanceDrainingto drain on Rebalance in Queue Processor mode?
brycahta
approved these changes
Apr 12, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #368
Description of changes:
Currently NTH will only cordon a node when a rebalance recommendation signal is received. This PR adds the ability to also drain the node when such signal is received.
Also adding a couple of missing parameters in the Helm chart.