DDB Enhanced:Added support to read Nested objects in attributesToProj… #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect Scan and query requests
|
SonarCloud Quality Gate failed.
|
dagnir
reviewed
Sep 10, 2020
| private static boolean isAttributeToProjectAnExpression(final String attr, | ||
| final Map<String, String> projectExpressionNamesMap) { | ||
| return projectExpressionNamesMap != null | ||
| && projectExpressionNamesMap.keySet().stream().filter(key -> attr.contains(key)).findAny().isPresent(); |
There was a problem hiding this comment.
Can this expression be replaced with Map#containsKey?
dagnir
reviewed
Sep 10, 2020
| @@ -56,6 +56,12 @@ private ScanOperation(ScanEnhancedRequest request) { | |||
| return new ScanOperation<>(request); | |||
| } | |||
|
|
|||
| private static boolean isAttributeToProjectAnExpression(final String attr, | |||
There was a problem hiding this comment.
Maybe consider extracting to a utility class
There was a problem hiding this comment.
Closing the Pull request without merge as will use other user friendly approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description DDB Enhanced: Added support for Nested objects projection expressions BugReportLink
Motivation and Context
Root Cause
Fix
Why have we created a new parameter called attributesToProjectExpressionNames and not used expressionAttributeNames of
software.amazon.awssdk.services.dynamodb.model.QueryRequest?Testing
This case is same as attributesToProjectExpressionNames not specified or null.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense