Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy byte array in OutputStreamPublisher #5964

Closed
wants to merge 1 commit into from

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Mar 17, 2025

Modifications

Copy byte array in OutputStreamPublisher

Testing

Added integ tests and unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner March 17, 2025 00:42
@joviegas
Copy link
Contributor

Dow we need Change logs ?

@zoewangg zoewangg added this pull request to the merge queue Mar 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 17, 2025
@davidh44 davidh44 added this pull request to the merge queue Mar 17, 2025
@zoewangg zoewangg removed this pull request from the merge queue due to a manual request Mar 17, 2025
@zoewangg
Copy link
Contributor Author

Closing because we merged the change upstream (with changelog added)

@zoewangg zoewangg closed this Mar 17, 2025
@zoewangg zoewangg deleted the zoewang/forBlockingOutputStream branch March 17, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants