fix(packages): maintain singleton config object #6959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
fix/object-ownership
branch
from
7c7bac3 to
0b7c699
Compare
kuhe
force-pushed
the
fix/object-ownership
branch
2 times, most recently
from
e84ade3 to
3dcd29f
Compare
kuhe
force-pushed
the
fix/object-ownership
branch
2 times, most recently
from
f8bc334 to
9e28d8a
Compare
kuhe
commented
Mar 23, 2025
| endpointDiscoveryEnabled !== undefined | ||
| ? () => Promise.resolve(endpointDiscoveryEnabled) | ||
| : endpointDiscoveryEnabledProvider, | ||
| isClientEndpointDiscoveryEnabled: endpointDiscoveryEnabled !== undefined, |
There was a problem hiding this comment.
this boolean seems wrong... what if endpointDiscoveryEnabled === false?
not related to this PR though
kuhe
commented
Mar 23, 2025
| export const resolveTokenConfig = <T>(input: T & TokenInputConfig): T & TokenResolvedConfig => { | ||
| const { token } = input; | ||
| return Object.assign(input, { | ||
| token: token ? normalizeTokenProvider(token) : tokenDefaultProvider(input as any), |
There was a problem hiding this comment.
this fallback makes no sense to me since input has no overlap with FromSsoInit, the type of the falsy branch.
kuhe
force-pushed
the
fix/object-ownership
branch
from
9e28d8a to
4249188
Compare
trivikr
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to smithy-lang/smithy-typescript#1550
This change makes all config resolvers mutate the input config instead of creating a shallow copy. The shallow copies, if preserved by references, can result in reading inconsistent config data.