Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass through credentials parameters when wrapping the provider #6961

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

RossWilliams
Copy link
Contributor

Issue

#6960

Description

Passes through credentials parameter object when wrapping the credential provider

Testing

Minimal reproduction example in linked issue

Additional context

Fixes inadvertent behaviour change. Issue recently rolled out into bundled Lambda runtime.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@RossWilliams RossWilliams requested a review from a team as a code owner March 22, 2025 12:51
@RossWilliams
Copy link
Contributor Author

The types in Smithy-lang/smithy-typescript here could also be tightened to require the first parameter so that it does not get accidentally invoked without passing it in. This is probably important in the aws-sdk-js-v3 codebase that does a lot of layering.

Copy link
Contributor

@kuhe kuhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right as a fix.

@trivikr trivikr merged commit 3f9fdc0 into aws:main Mar 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants