Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add App Mesh controller and injector charts #1

Merged
merged 18 commits into from
Oct 2, 2019
+1,169 −5
Merged

Add App Mesh controller and injector charts #1

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4417ef4
Init CI for Helm charts
stefanprodan Oct 1, 2019
c83344a
Add App Mesh controller chart
stefanprodan Oct 1, 2019
3735441
Add App Mesh CRDs
stefanprodan Oct 1, 2019
43f5010
Add App Mesh controller install command to docs
stefanprodan Oct 1, 2019
36fc916
Add pod security policy to App Mesh controller
stefanprodan Oct 1, 2019
52d562e
Validate all stable charts
stefanprodan Oct 1, 2019
a8ab409
Add service account to App Mesh controller
stefanprodan Oct 1, 2019
d3edabc
Set App Mesh controller image tag in values
stefanprodan Oct 1, 2019
f1cb890
Add App Mesh controller health check
stefanprodan Oct 1, 2019
88a0225
Use exec for liveness and readiness probes
stefanprodan Oct 1, 2019
1d7868d
Init App Mesh inject chart
stefanprodan Oct 2, 2019
f1e2632
Generate certs for App Mesh inject webhook
stefanprodan Oct 2, 2019
1b50405
Add optional mesh definition to App Mesh inject
stefanprodan Oct 2, 2019
6e0c63d
Add App Mesh inject install to readme
stefanprodan Oct 2, 2019
a70c797
Disable App Mesh inject scraping
stefanprodan Oct 2, 2019
4c34f9f
Set App Mesh inject service type to ClusterIP
stefanprodan Oct 2, 2019
0c437a8
Add Envoy resources requests to App Mesh inject
stefanprodan Oct 2, 2019
83ccd02
Add migration procedure from App Mesh scripts to Helm
stefanprodan Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add App Mesh inject install to readme 
Signed-off-by: stefanprodan <[email protected]>
@stefanprodan
stefanprodan committed Oct 2, 2019
commit 6e0c63d7ff97437048bbb02e2698e90337a5060f
11 changes: 10 additions & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
@@ -22,12 +22,21 @@ Apply the App Mesh CRDs:
kubectl apply -f https://raw.githubusercontent.com/aws/eks-charts/master/stable/appmesh-controller/crds/crds.yaml
```

Install the App Mesh controller:
Install the App Mesh CRD controller:

```sh
helm upgrade -i appmesh-controller eks/appmesh-controller --namespace appmesh-system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is namespace expected to always be passed? Can we add a default namespace?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default namespace is default same as with kubectl. Helm v3 doesn't support namespace definitions and that's a good thing :) it uses the kubectl context for that.

```

Install the App Mesh admission controller:

```sh
helm upgrade -i appmesh-inject eks/appmesh-inject \
--namespace appmesh-system \
--set mesh.create=true \
--set mesh.name=global
```
Comment on lines +33 to +38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below this block, maybe we can have a note about upgrading the existing installation before the helm chart existed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!


## License

This project is licensed under the Apache-2.0 License.