Skip to content

Support ECR pull-through cache repos #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
artem-nefedov opened this issue Mar 28, 2025 · 2 comments · Fixed by #7963
Closed

Support ECR pull-through cache repos #7956

artem-nefedov opened this issue Mar 28, 2025 · 2 comments · Fixed by #7963
Labels
documentation Improvements or additions to documentation triage/accepted Indicates that the issue has been accepted as a valid issue

Comments

@artem-nefedov
Copy link
Contributor

artem-nefedov commented Mar 28, 2025

Description

Example CFN template should create node role with IAM permissions to pull images from ECR pull-through cache repositories (PTC).

Currently (v1.3.3), node role is missing ecr:BatchImportUpstreamImage permission, which is absent in AmazonEC2ContainerRegistryReadOnly managed policy and present in AmazonEC2ContainerRegistryPullOnly managed policy. This permission is required to be able to pull new images from PTC repos.

In general, AmazonEC2ContainerRegistryReadOnly can be replaced with AmazonEC2ContainerRegistryPullOnly with no downsides. This will also remove unneeded permissions defined in ReadOnly role, thus making it better suited for the least privilege principle, and match the current AWS recommendations for node role.

NOTE: EKS Auto Mode already uses AmazonEC2ContainerRegistryPullOnly.

@artem-nefedov artem-nefedov added documentation Improvements or additions to documentation needs-triage Issues that need to be triaged labels Mar 28, 2025
@jonathan-innis
Copy link
Contributor

Do you want to open a PR to make this change to our docs? Given that this is for creating new clusters, I think that it's fine to push this out if you want to open the PR

@jonathan-innis jonathan-innis added triage/accepted Indicates that the issue has been accepted as a valid issue and removed needs-triage Issues that need to be triaged labels Mar 31, 2025
@artem-nefedov
Copy link
Contributor Author

@jonathan-innis done, please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation triage/accepted Indicates that the issue has been accepted as a valid issue
Projects
None yet
2 participants