Skip to content

docs: Change node role policy ReadOnly -> PullOnly (support ECR pull-through cache) #7963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

artem-nefedov
Copy link
Contributor

@artem-nefedov artem-nefedov commented Apr 1, 2025

fixes #7956

@artem-nefedov artem-nefedov requested a review from a team as a code owner April 1, 2025 12:51
@artem-nefedov artem-nefedov requested a review from DerekFrank April 1, 2025 12:51
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit bcb7bc6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67ebe142397355000820396d
😎 Deploy Preview https://deploy-preview-7963--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Apr 1, 2025

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-bcb7bc627d824b3cce204eff5c7c53a59d362a12.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-bcb7bc627d824b3cce204eff5c7c53a59d362a12" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14196082910

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 66.404%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 95.12%
Totals Coverage Status
Change from base Build 14183913859: -0.02%
Covered Lines: 6732
Relevant Lines: 10138

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) April 4, 2025 15:41
@jonathan-innis jonathan-innis merged commit b25d73e into aws:main Apr 4, 2025
35 checks passed
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ECR pull-through cache repos
3 participants